Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clustering does not trigger initially for billboards for undefined width/height #8060

Closed
HapDragon opened this issue Aug 14, 2019 · 1 comment

Comments

@HapDragon
Copy link
Contributor

I have just found that when entity has billboard property but not set width and height, the datasource clustering will not run when its data firstly added.
It is because in entitycluster function: createDeclutterCallback, the variable bbox needs the width and height properties, if it is undefined, everty property in bbox will be NaN.

So I think it is probablely need to set _width and _height a defined value in entity billboard object, or modify some code in entitycluster object.

Sandcastle example:
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=tVhtb9s2EP4rRPbB0uJIsp0Ame0YS1KvC+bUQZx2GOZioCTaJiJLAkk5yQb/9x0l6l2K03QzWlsij/fcHY/PHbPDDO0oeSIMXSCfPKFrwmm0Nb7EY1rHiV+vA19g6hPW0UdLf+nvYFUQChr4HJb9s/QRfBy8JQyjodJncIf4xEhGu6kILOV1ETm69PeZbhcLvAgi5pA7FmwpJxdqQT7BDey6WsHi64iLYPshE9D0xNaaLkNsiK+tIt+RDmj5vJ56sgqYJs2gF9aIjgcWfB8f68mcEpGffKVBfEEFVUYVROQnDDiVSMPMUswEPGF/YKzApA9kzQjh2i0WG4Nh3w22mv5j79zqovLQTzBi6d2ydpt6nh1g5g5RBVd+6BavyRAtjwzDzP5dhiE3F3gbekSGy1xRRozQXy+PunUNpvlEXbEZ9iyra5p0heJXBDahDaHrjUCUI05ElwqY8jzkeLARkE5OwBhxhEfQE8Q7DhYCJC6QF2CXuDUo01QaJVbdkMrIvnEuF9qr/donP/F38ih3NqTPxLvH/ppA/vbORvnMlvp0CxmfeLGgf0uJQUGA+Nj2iAujgkUkTrFKMqgIUH9t5MLqafSadMmq/OXVNY321gczO6ULjGyDHZlRmIQzXZoKqX8VUc+t8sFdNq7po5L4mRUbm07HKf1AnoXWObOOO90s6QMvYMb99EMXnZ7rhghk6n2+n1XVnbaqO62rm99ffvo4PaBx0KpxUNf4x3Q2m/9+QGO/VWO/rvHj/XT66YDCXqvCXl3h1exzo8u5Rg6JAWebrqmAfeNqJy8Zwy/aeQoNJIcSloN5awQ/4+pCwyP+WmxG6PiY6kV6qcj9Sb+22d9Bx0ij8NXXK258uZnPpg9tgdmn/qQ8jZyY3xfixQNqLxoDnKQpzS5ZQZVytXKC63qVGsvzGWjzNLgW+UpzQXCPiMfJ65phafOpVY/THRQOWTPih8yerDYpMeJOVX3ppvSqN7G9mjM8bBPP4JvgCQxYYTBz1C6cFZB0gaK1w/JU8loZk7pvWrkjTFAHe3MGKeSDlrTrKI0bV/OHh/ltltqlwgabXouOylc0uUBnVmOEWhyRVTLJ4DOrwQG11YcwT9+JefodmIN3Yg6+A7P/Tsz+d2D23onZewXzm/VVaa/V4BPU/9qEWx7aF3lnX8xyaIWAnh2CMBDKSdpRPVFQDc1rzOYciBDMydfU2ppDPcaosZNta0esbxOvwWT+gW9cQAecuJOweuwNUXeEIs+Xypq8A9wGLvHyO0fcX2dQw8JzoZWtd0PDhjFlpjJXEdKjHziPQSQMwbDzqGUWlA0TQeDZOGb7wIm2ktPXREw9Ih+vXm5craNEOnqLfhyG3ssV9V2IJM9xuqnuHDAriDyyucOoTe4wg0sWuKH58Fs6J1UYMGtuc8J2shktwsQrjUylVs7UrCBB5n3BXkQaD2NjWvwpNX9NWpB4aeVcFM5ErfY3eNjJdziLZZNYfX87eQgXcHtxMIe7iay9D8EaTvVVJAQ42JkmfTo0XbIOdnPXnQ1xHomrt9wAG5t+tSb1620WJBdZtEgO+FsMqR6ZCphM0Q0AetWmfuHAxdNfhNghcQPyayKkNdzOU7VKjwE3vhs/jMRlYlNmnOx+ZNaXwpRQkzR6JrsEMKKEIKeyhUZ6XS6SY0OLV9BX7+/ittblMQ9lYvXmpKCW8qQ9hlV6Y3I3tcsg3Noil3Bc2SIXCoojO+C87cnuRm+oGaWKEf9027bz4SUkxmz6y8Nf17Ob699kQFVWHHWPxjHlThIdP9NtGAAlR8zTDMMUZBt6WBBu2hGETxgOzxLgh5TsCr7awI1rFkCXPERsbWPttA99vfpvGefFrQwh3yGth+g0fC4M2wGDi8MJwy6NeHFyX4GlMutKyaV6xhPs0bUvmd2FDK0jnoggHKJ+CTWdsgM4etviLMCOzTREY5fuoC3AnF8sj1aR58X14gj2Fd4rfyFbHk3GJsiny2IZ+RcPwJmDrR5+kSKb3mSWDBqGMTbhtb5KuQziiU1jIXllkps/FnbgvkzGgk3KWTIW7uROEiWKmXJswntdop5s4yS6AhIH8JlcC24Cl8JbTz7hZ3jqWxY8A9uFaljS4IkNxQved5LjS4UYxUOfQ5CCiU4M0cmcaocXcIGUOBBrCXoIp6ax4jW8slLsmoJ2m5QNpOoGkhv9n0SvX4jeweDVi9f/G8SGZugbg2kmmajy1EwTNc3pfwE

Browser: Chrome 64

Operating System: win10

@HapDragon HapDragon changed the title entitycluster with billboard did not run correctle when entity has billboard property and not set width and height entitycluster with billboard did not run correctly when entity has billboard property and not set width and height Aug 14, 2019
@OmarShehata OmarShehata changed the title entitycluster with billboard did not run correctly when entity has billboard property and not set width and height Clustering does not trigger initially for billboards for undefined width/height Aug 16, 2019
@OmarShehata
Copy link
Contributor

I actually think this is the same issue as #7767. Your Sandcastle highlights the fact that it is indeed the width/height that's the issue here.

I'm going to close this and add your Sandcastle there. Thanks again for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants