Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane entity not rotating correctly #8268

Closed
IanLilleyT opened this issue Oct 9, 2019 · 2 comments · Fixed by #9112
Closed

Plane entity not rotating correctly #8268

IanLilleyT opened this issue Oct 9, 2019 · 2 comments · Fixed by #9112

Comments

@IanLilleyT
Copy link
Contributor

IanLilleyT commented Oct 9, 2019

This came up in a forum post.

Sandcastle demonstration.

Select Plane Z and then select between Heading, Pitch, and Roll in the second drop down. Notice how Heading looks exactly the same as None. For comparison, select Box from the first drop down.

I tracked it down to PlaneGeometryUpdater : createPrimitiveMatrix. If the function becomes just return transform;, the Z-Plane works, but then the X and Y planes become Z-planes too.

I think the core problem is how the up vector gets set, since it ignores transform. If the function is passed two different transforms with the same Z column, such as when Heading vs None is selected, the resulting matrix will be the same.

Any thoughts @hpinkos, @OmarShehata?

@baothientran
Copy link
Contributor

baothientran commented Aug 25, 2020

I haven't tested it thoroughly, but if the plane is transformed/oriented in the local coordinate using the plane's normal and distance as they are, then multiply the local matrix with the transform to convert to world coordinate, it works for me

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/_S5Z3oaJdvQ/_JEOWflNBQAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #8268 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants