Heading Tilt #1131
Merged
Heading Tilt #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var tilt = this.getTilt(); | ||
| angle = angle - tilt; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Remove commented out code.
|
@bagnell this is good with me, but do you want to move the entire camera to get/set properties instead of functions since these are not performance critical? Or perhaps I should ask: how much of the camera is called more than once per frame? Perhaps some getters for automatic uniforms? Maybe we could provide fast accessors for those until browsers get their act together. |
|
@emackey just branch off this in the meantime. Why bring something into master that we might change in a day or two? |
|
@pjcozzi This is ready for another review. I changed the camera to use get/set properties. |
|
Looks good. Update the camera tutorial if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
getHeading,setHeading,getTiltandsetTilttoCameraControllerfor #977 and #1111.Roll was unneeded. It can be done with:
camera.controller.look(camera.direction, angle);