New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1749 by adding an OIT flag. #2120
Conversation
Thanks @emackey. Can you update README.md, add a test, and rename to |
OIT uses a few textures and framebuffers. You may want to create/destroy it to create/release those resources. |
If this requires anything but completely trivial code, let's do what I suggested in #1749 since there is no value in being able to do this at runtime other than for a tech demo that we already have. |
Regardless, this should get pass through the constructors too. |
This is moved to the constructors to save resources. Setting to Also, our By README.md, did you mean CHANGES.md? |
Ah, yes, CHANGES.md.
Wouldn't worry about it for now. Tests like these would be OK: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/Widgets/Viewer/ViewerSpec.js#L285 We could also add a rendering test with a spy to ensure it disables OIT (assuming the system supports OIT) but it is borderline overkill. Also, I want to make a few tweaks to cleanup the logic but I won't be able to get to it until next week after FOSS4G. |
Tests added, other comments addressed. @pjcozzi just tell me what cleanup is needed and I'll clean it up, or open a separate PR after FOSS4G, but please don't let another branch go stale. |
This still needs a readonly like Bare with me on the review as I am on travel working around the clock for us. |
Great suggestions, thanks. Code is cleaner as a result. |
Thanks! |
Fix #1749 by adding an OIT flag.
Turns out OIT can be easily turned on and off at runtime, for example picking temporarily disables it.