Improve Camera Flights #2825

bagnell · 2015-06-22T19:16:44Z

Improved camera flights. Fixes Camera flight path in Columbus View ends at wrong destination #802, Camera flight path in 2D tries to fly through the map #804, Long camera flights #1158, Easy to break camera in Columbus View #1400, flyToRectangle doesn't work with rectangles that cross the IDL #2093, Specifying a flyTo pitch of -90 degrees causes crazy flights #2468
Adds easing function and max altitude options to flights.
Removed deprecated Camera.clone Remove Camera.clone #2763

TODO

Fix/update tests
Update CHANGES.md
Deprecate unused splines and submit issues for them
Update Sandcastle example for common use cases, e.g., global view, city view, etc.

CC #1060

…hange flight duration based on distance.

pjcozzi · 2015-06-22T20:51:51Z

I updated the TODO list in this issue:

Deprecate unused splines and submit issues for them

pjcozzi · 2015-06-22T20:52:39Z

Source/Scene/Camera.js

@@ -2299,6 +2315,8 @@ define([
     * @param {Matrix4} [options.endTransform] Transform matrix representing the reference frame the camera will be in when the flight is completed.
     * @param {Boolean} [options.convert=true] When <code>true</code>, the destination is converted to the correct coordinate system for each scene mode. When <code>false</code>, the destination is expected
     *                  to be in the correct coordinate system.
+     * @param {Number} [options.altitude] The maximum altitude at the peak of the flight.


Throughout Cesium, we call this height. We should do the same here unless we have a compelling reason.

Or maximumHeight.

pjcozzi · 2015-06-22T20:58:18Z

Also added this to the TODO:

Update Sandcastle example for common use cases, e.g., global view, city view, etc.

pjcozzi · 2015-06-22T21:04:15Z

Switch to CV, then back to 3D. The home view is too close. It is: http://localhost:8080/Apps/CesiumViewer/index.html?view=-90%2C26.641969128869164%2C6382419.6691765785%2C360%2C-89.84575039834716%2C0

pjcozzi · 2015-06-22T21:05:36Z

The flight from, for example, Exton to LA feels a bit too "square" if you know what I mean.

pjcozzi · 2015-06-22T21:12:55Z

The flight from, for example, Exton to LA feels a bit too "square" if you know what I mean.

When it is a bit slower, I think this is fine.

pjcozzi · 2015-06-22T21:14:34Z

The Cesium API and Geocoder/Home flights seem to have different durations. Why not have the same default for both?

pjcozzi · 2015-06-22T21:19:06Z

To freeze when morphing:

Run http://localhost:8080/Apps/Sandcastle/index.html?src=Camera.html&label=Showcases
Switch to 2D
Fly to rectangle
Then switch to CV.

I'm pretty sure this is because the morph started before the flight finished.

pjcozzi · 2015-06-22T21:21:51Z

The CV flights tend to dip early then fly low to the ground. Instead, if we dip late then zoom closer to directly in, I bet it will look better and load fewer tiles since it is not requesting all the high res tiles when moving quickly.

For example:

Run http://localhost:8080/Apps/Sandcastle/index.html?src=Camera.html&label=Showcases
Switch to CV
Select "Fly to San Diego"

mramato · 2015-06-25T13:42:10Z

The home flight is now WAY to long. Can we change it so the unified defaults use the old home flight value.

After playing with it some more, the default flight time in general is way to long. I would recommend we make it no longer than 1 second. I think this also has to do with the fact that flight length (in meters traveled) seems to be significantly less without the bouncing.

mramato · 2015-06-25T13:51:11Z

Change the last line of the below example to viewer.flyTo(viewer.entities); In this branch the end view is incorrect.

1.10: http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Polygon.html&label=Geometries
branch: http://localhost:8080/Apps/Sandcastle/index.html?src=Polygon.html&label=Geometries

mramato · 2015-06-25T14:29:42Z

I think this fixes #2073 as well. @bagnell can you confirm.

mramato · 2015-06-25T14:40:23Z

Source/Scene/CameraFlightPath.js

+        var duration = options.duration;
+        if (!defined(duration)) {
+            duration = Math.ceil(Cartesian3.distance(camera.position, destination) / 1000000.0) + 3.0;
+            duration = Math.min(duration, 10.0);


This line seems to be the cause of the extremely slow fights that I'm seeing (10 seconds). I would suggest changing these two lines to the below, which I feel works much better in all of the test cases I've tried.

duration = Math.ceil(Cartesian3.distance(camera.position, destination) / 1000000.0) + 1.0; duration = Math.min(duration, 2.0);

mramato · 2015-06-25T14:43:24Z

That's all I've got for now, this is an awesome change.

Conflicts: CHANGES.md

pjcozzi · 2015-06-26T12:34:55Z

@bagnell can you reply here: https://groups.google.com/forum/#!topic/cesium-dev/90utjnigscg

I imagine this is just use LINEAR?

pjcozzi · 2015-06-26T12:37:27Z

CHANGES.md

 * Deprecated
+  * `CatmullRomSpline` has been deprecated and will be removed in Cesium 1.12.


Maybe we should rethink this: https://groups.google.com/forum/#!topic/cesium-dev/MMIdPKFNR2s

Deprecating HermiteSpline is still OK though.

Might want to keep both and add others. Depends on what direction is taken for tools in Viewer. Also, GML uses b-spline and cubic spline which I believe are for roads.

I'm fine with not deprecating these and reevaluating in the future.

@GatorScott I added cubic b-splines and bezier splines a while back for model animation. They're sitting in the splines branch if we ever need them.

pjcozzi · 2015-06-28T18:17:33Z

@bagnell anything left here? Let's aim to merge this on Monday for 1.11.

mramato · 2015-06-29T16:00:31Z

#2468 still seems to be a problem.

bagnell · 2015-06-29T18:09:23Z

@pjcozzi I removed the deprecation from CatmullRomSpline and HermiteSpline. This is ready.

bagnell · 2015-06-29T18:39:37Z

@mramato #2468 is fixed again. I broke it when adding a fix for flying to the bounding sphere of the polygon Sandcastle demo.

bagnell · 2015-06-29T18:45:56Z

It seems that #2073 is fixed but I haven't been able to reproduce it in master either.

Conflicts: CHANGES.md

mramato · 2015-06-29T19:56:48Z

A big 👍 from me. @pjcozzi feel free to merge if you're happy.

pjcozzi · 2015-06-29T22:31:58Z

Awesome, will review and merge first thing tomorrow.

Improve Camera Flights

pjcozzi · 2015-06-30T12:17:55Z

@bagnell can you still reply to Gaurav on the forum?

bagnell and others added 20 commits May 29, 2015 18:42

New camera flights in 3D and Columbus view. Orientation is a WIP.

4abb5ed

Merge branch 'master' into flights

344fb79

Fix the direction of the heading when linearly interpolating.

c305c1a

Fix the direction of the roll when linearly interpolating.

b7ebaea

Fix flights in Columbus view.

9c07e21

Add quadtratic function for the height during flights.

c8db4b0

Merge branch 'master' into flights

34eafd8

Replace quadratic height function with eighth degree polynomial and c…

33aa598

…hange flight duration based on distance.

Tweaking numbers per conversation with Dan.

8c4811c

Add fly to altitude to Columbus view.

8e9c965

Rewrite 2D flights and some clean-up.

ec9219c

Clean up logic for creating tweens for flight animations.

63d96ac

Fix flying to bounding sphere.

cceb9be

Simplify home view flights.

49b0f19

Compute heading/pitch/roll from vectors for backwards compatibility.

e825371

Move altitude and easing function parameters up to Camera.flyTo.

9212dcf

Add doc for the easing function.

d647e4b

Removes deprecated camera clone.

6fb8bdb

Fix flights in 2D.

d271c0a

Fix flights to rectangles that cross the IDL in 2D and COlumbus view.

8cec20d

pjcozzi reviewed Jun 22, 2015
View reviewed changes

mramato reviewed Jun 25, 2015
View reviewed changes

bagnell added 4 commits June 25, 2015 16:37

Fix flying to bounding spheres.

a204fb6

Update CHANGES.md.

9bd5471

Merge branch 'master' into flights

8307f82

Conflicts: CHANGES.md

Speed up default flights.

964b7fc

pjcozzi reviewed Jun 26, 2015
View reviewed changes

bagnell added 2 commits June 29, 2015 14:05

Remove deprecation from CatmullRomSpline and HermiteSpline.

be37c09

Merge branch 'master' into flights

7585dd1

Fix flying to a bounding sphere when the pitch was -90 degrees.

1cbcc37

Merge branch 'master' into flights

aca37d6

Conflicts: CHANGES.md

Merge master to flights

7bce4d7

This was referenced Jun 30, 2015

Camera exception during morph #1880

Closed

Home button does not work as expected when in Columbus view #2073

Closed

pjcozzi added a commit that referenced this pull request Jun 30, 2015

Merge pull request #2825 from AnalyticalGraphicsInc/flights

a48142a

Improve Camera Flights

pjcozzi merged commit a48142a into master Jun 30, 2015

pjcozzi deleted the flights branch June 30, 2015 12:16

mramato mentioned this pull request Sep 28, 2015

Documentation update #3047

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Camera Flights #2825

Improve Camera Flights #2825

bagnell commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi Jun 22, 2015

pjcozzi Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

mramato commented Jun 25, 2015

mramato commented Jun 25, 2015

mramato commented Jun 25, 2015

mramato Jun 25, 2015

mramato commented Jun 25, 2015

pjcozzi commented Jun 26, 2015

pjcozzi Jun 26, 2015

GatorScott Jun 27, 2015

pjcozzi Jun 28, 2015

bagnell Jun 29, 2015

pjcozzi commented Jun 28, 2015

mramato commented Jun 29, 2015

bagnell commented Jun 29, 2015

bagnell commented Jun 29, 2015

bagnell commented Jun 29, 2015

mramato commented Jun 29, 2015

pjcozzi commented Jun 29, 2015

pjcozzi commented Jun 30, 2015

		* Deprecated
		* `CatmullRomSpline` has been deprecated and will be removed in Cesium 1.12.

Improve Camera Flights #2825

Improve Camera Flights #2825

Conversation

bagnell commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi Jun 22, 2015

Choose a reason for hiding this comment

pjcozzi Jun 22, 2015

Choose a reason for hiding this comment

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

pjcozzi commented Jun 22, 2015

mramato commented Jun 25, 2015

mramato commented Jun 25, 2015

mramato commented Jun 25, 2015

mramato Jun 25, 2015

Choose a reason for hiding this comment

mramato commented Jun 25, 2015

pjcozzi commented Jun 26, 2015

pjcozzi Jun 26, 2015

Choose a reason for hiding this comment

GatorScott Jun 27, 2015

Choose a reason for hiding this comment

pjcozzi Jun 28, 2015

Choose a reason for hiding this comment

bagnell Jun 29, 2015

Choose a reason for hiding this comment

pjcozzi commented Jun 28, 2015

mramato commented Jun 29, 2015

bagnell commented Jun 29, 2015

bagnell commented Jun 29, 2015

bagnell commented Jun 29, 2015

mramato commented Jun 29, 2015

pjcozzi commented Jun 29, 2015

pjcozzi commented Jun 30, 2015