Also bind tilt to ctrl-right-drag. #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Firefox, on OS X, it is impossible to ctrl-left-click, on a laptop with a trackpad. Because OS X typically interprets ctrl-click as a secondary ("right") click, Firefox "helpfully" decides to send a right-click JS mouse event, unlike both Chrome and Safari.
This new mouse binding affects all platforms, but ctrl-right-drag wasn't bound to anything by default anyway.
|
Sounds good to me. Update CHANGES.md, please (for 1.13 since we are releasing 1.12 on Monday). Does anyone else want to look at this? @emackey? |
|
I tested this on Firefox 39.0 on Mac OSX 10.10.4 and it works like a charm. Thank you! |
Forgot to stage all changes.
|
I updated changes. Given this is a no/low impact change and people have mentioned it on the forum several times in the past, I see no reason why this can't go into 1.12. @pjcozzi any objections? I didn't want to just hit merge since you assumed this is for 1.13. |
|
Nah, 1.12 is OK. Please follow up on the forum. |
pjcozzi
added a commit
that referenced
this pull request
Aug 2, 2015
Also bind tilt to ctrl-right-drag.
|
Thanks @shunter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox, on OS X, it is impossible to ctrl-left-click, on a laptop with a trackpad. Because OS X typically interprets ctrl-click as a secondary ("right") click, Firefox "helpfully" decides to send a right-click JS mouse event, unlike both Chrome and Safari.
This new mouse binding affects all platforms, but ctrl-right-drag wasn't bound to anything by default anyway.