Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #2918

Merged
merged 2 commits into from
Aug 5, 2015
Merged

Documentation fixes #2918

merged 2 commits into from
Aug 5, 2015

Conversation

slozier
Copy link
Contributor

@slozier slozier commented Aug 4, 2015

No description provided.

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 5, 2015

Awesome @slozier, thanks for all these doc improvements!

Can you send in a Contributor License Agreement (CLA) so we can review and merge this? See CONTRIBUTING.md and let us know if you have any questions.

@@ -227,7 +227,7 @@ define([
*
* @function
*
* @returns String The full GLSL fragment shader source.
* @returns {String< The full GLSL fragment shader source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be {String}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 5, 2015

Thanks @slozier. Could you make that one fix please?

@slozier
Copy link
Contributor Author

slozier commented Aug 5, 2015

@pjcozzi
Looks like I will probably have more documentation fixes over the coming days. Should I make another pull request when I have another batch of corrections or should I add them to this one?

pjcozzi added a commit that referenced this pull request Aug 5, 2015
@pjcozzi pjcozzi merged commit 8ecfd97 into CesiumGS:master Aug 5, 2015
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 5, 2015

@slozier A separate pull request will make it easier to review. Thanks again for these fixes and thanks in advance for the next batch!

@slozier slozier deleted the doc_fixes branch August 7, 2015 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants