Add ability to create open extruded PolygonGeometry #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on the NYC 3D Tiles demo, I needed to create open Polygon geometry (for example, a building with a different color roof). Having a top and bottom on the polygon was inefficient and also caused z-fighting.) Also added feature to CZML and Entity API as well as tweaked Sandcastle examples to show it.
|
|
|
That's probably a good idea (I originally wanted something similar but didn't know Rectangle already had it). I was having trouble figuring out how to separate the two, since they seem to be genereated together currently. |
|
I can take a look at it. I think I can do it really easily. |
|
👍 Thanks |
Add closeTop and closeBottom to PolygonGeometry
|
Okay, this should be good to go. @bagnell, you should probably take a quick look at PolygonGeometry.js, everything else is pretty striaghtforward. |
|
|
||
| it('computes positions extruded and not closeBottom', function() { | ||
| var p = PolygonGeometry.createGeometry(PolygonGeometry.fromPositions({ | ||
| vertexFormat : VertexFormat.POSITION_ONLY, |
There was a problem hiding this comment.
We should probably revert the Cesium-only tweak to the WebStorm defaults that is causing this to happen on format. So annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the NYC 3D Tiles demo, I needed to create open Polygon geometry (for example, a building with a different color roof). Having a top and bottom on the polygon was inefficient and also caused z-fighting.)
Also added feature to CZML and Entity API as well as tweaked Sandcastle examples to show it.
This also makes it easier for users who want to create a polygon with different top/bottonm materials, which is often asked about on the mailing list (and doesn't work with walls because of interpolation).