Fix can't read x of undefined when getting window coordinates #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain situations, 2D mode and zoomed out far, calling SceneTransforms.wgs84ToWindowCoordinates without passing in a result object results in "TypeError: Cannot read property 'x' of undefined".
| @@ -192,4 +192,19 @@ defineSuite([ | |||
| expect(drawingBufferCoordinates.x).toBeLessThan(1.0); | |||
| expect(drawingBufferCoordinates.y).toBeLessThan(1.0); | |||
| }); | |||
|
|
|||
| it('should not error when zoomed out and in 2D', function(done) { | |||
| var scene = createScene(); | |||
There was a problem hiding this comment.
I had to create a new scene instead of using the one that was created in the beforeAll block because changes I made to it were impacting other tests. I can update this spec be a little less fragile by creating the scene in the beforeEach instead of just once if that's preferred.
There was a problem hiding this comment.
Creating a Scene for this test is fine, but you need to call destroyForSpecs afterwards to release all WebGL resources.
|
That's the only comment. Thanks @bmcallis! |
|
Also, could you update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations, 2D mode and zoomed out far, calling
SceneTransforms.wgs84ToWindowCoordinates without passing in a result
object results in "TypeError: Cannot read property 'x' of undefined".