Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PolylinePipeline.generateArc to accept an array of heights for one position #4155

Merged
merged 4 commits into from
Aug 1, 2016

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 27, 2016

PolylinePipeline.generateArc accepts either a number or array of numbers for the height value. However, if there was only one position, the function was only expecting height to be a number instead of an array. This adds a check so I can do something like this:

var newPositions = PolylinePipeline.generateArc({
    positions: [myPosition],
    height: [30]
});

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 31, 2016

Good catch. Update CHANGES.md with this minor fix.

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 1, 2016

@pjcozzi ready

# Conflicts:
#	CHANGES.md
@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 1, 2016

Thanks!

@pjcozzi pjcozzi merged commit 50aac92 into master Aug 1, 2016
@pjcozzi pjcozzi deleted the generateArcFix branch August 1, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants