Fix polygon offset check for shadows #4559
Conversation
|
Update CHANGES. Do we want this for tomorrow's release? Seems like an obvious fix. |
Updated. Yes this ought to go in. |
lilleyse
force-pushed
the
shadows-polygon-offset
branch
from
ae9f803
to
300191d
Compare
| @@ -185,8 +185,9 @@ define([ | |||
| this._needsUpdate = true; | |||
|
|
|||
| // In IE11 polygon offset is not functional. | |||
| // TODO : Also disabled for Chrome temporarily. Re-enable once https://groups.google.com/forum/#!topic/webgl-dev-list/E1dAG65QBhg is resolved. | |||
There was a problem hiding this comment.
Write up a Cesium bug instead of linking to a forum post. (the Cesium bug can include the above link, of course).
If we ever need to do this check in more than one place, we should move the code to FeatureDetection but it's fine here for now.
There was a problem hiding this comment.
Ok, the new issue is here: #4560
There was a problem hiding this comment.
If this is specifically an ANGLE problem, why are we disabling on Chrome in all cases? We have lots of non-ANGLE Chrome users (Mac/Linux/Android/iOS)
There was a problem hiding this comment.
Good point, the check is now Chrome + Windows
|
Thanks. |
Yeah...
I think the Chrome 49->50 switch happened right before I introduced this bug so I never noticed that I had accidentally turned polygon offset off.
Now shadow aliasing should be reduced in Firefox. However
glPolygonOffsetstill seems to have almost no effect in Chrome which I opened an issue for here: https://groups.google.com/forum/#!topic/webgl-dev-list/E1dAG65QBhg. Shadowing in Chrome works fine now in version 49 or when ANGLE is disabled in the current version.