Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czml properties changed as fillcolor #5754

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Conversation

esraerik
Copy link
Contributor

#5705 changed the example to reference to the fill color instead of outlineColor

@cesium-concierge
Copy link

@esraerik thanks for the pull request!

I noticed that CHANGES.md has not been updated. If this change updates the Cesium API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and bump this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Thanks again.

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lastly, can we change the fill color to something other than white to show the change? Perhaps reference the label outline color since it's pink.

"label" : {
"fillColor" : {
"rgba" : [255, 255, 255, 255]
var czml = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows up in Sandcastle as everything having an extra tab on the left.

]
},
"height" : 0,
"fillColor" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fill color is not specified by "fillColor", it'd be more like this:

"material" : {
            "solidColor" : {
                "color" : {
                    "reference" : "fillColor-reference#label.fillColor"
                }
            }
        }

See the CZML docs on polygons: https://github.com/AnalyticalGraphicsInc/czml-writer/wiki/Polygon

CHANGES.md Outdated
@@ -1,5 +1,9 @@
Change Log
==========
### 1.36 - 2017-08-17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be ### 1.37 - 2017-09-01, and it's not a breaking change.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 20, 2017

@ggetz can you review this? I updated the example

baseUrl : '../../../Source',
waitSeconds : 120
});
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here? It's not in any of the other sandcastle examples.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggetz that was generated when I saved the files directly from Sandcastle so I think it's intentional

@ggetz
Copy link
Contributor

ggetz commented Oct 20, 2017

@hpinkos Just that one comment

@hpinkos hpinkos merged commit b561e56 into CesiumGS:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants