gltf-pipeline fix for _BATCHID semantic #6036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for when a gltf with PBR uses the _BATCHID semantic or other underscored semantics. It only affected loading a gltf model, not a b3dm.
The gltf-pipeline PR is here with a couple more notes: CesiumGS/gltf-pipeline#340
Bug reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/qMKvqBUGsoE