Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltf-pipeline fix for _BATCHID semantic #6036

Merged
merged 1 commit into from Dec 8, 2017
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 7, 2017

This is a fix for when a gltf with PBR uses the _BATCHID semantic or other underscored semantics. It only affected loading a gltf model, not a b3dm.

The gltf-pipeline PR is here with a couple more notes: CesiumGS/gltf-pipeline#340

Bug reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/qMKvqBUGsoE

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

⚠️ I noticed that a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@likangning93
Copy link
Contributor

@lilleyse looks good! @pjcozzi merge when ready.

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 8, 2017

@lilleyse please update CHANGES.md in master if warranted.

@pjcozzi pjcozzi merged commit e48f172 into master Dec 8, 2017
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/qMKvqBUGsoE

If this issue affects any of these threads, please post a comment like the following:

The issue at #6036 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi pjcozzi deleted the gltf-pipeline-semantic-fix branch December 8, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants