removed the deprecations for planes in clipping plane collection and related items #6498
Conversation
|
@hanbollar, thanks for the pull request! Maintainers, we have a signed CLA from @hanbollar, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| // But until then, we have no way of telling if they changed since last frame, so we have to do a full udpate. | ||
| var refreshFullTexture = this._multipleDirtyPlanes || this._containsUntrackablePlanes; | ||
| // But until then, we have no way of telling if they changed since last frame, so we have to do a full update. | ||
| var refreshFullTexture = this._multipleDirtyPlanes; |
There was a problem hiding this comment.
When more than one ClippingPlane is updated in between rendered frames, we refresh the entire clipping plane texture instead of just selectively updating a few adjacent pixels.
Looks like with the new changes though we can replace all uses of refreshFullTexture below with just direct access to this._multipleDirtyPlanes.
|
Ah wait also update CHANGES.md to indicate the deprecation. |
|
@likangning93 finished updating |
|
Thanks @hanbollar and @likangning93 ! |
Fixes #6317
@likangning93 did the changes - i'm not sure what you'd want me to do for line 506 with the reload check so i left that part as is but just removed the additional boolean for if any planes instead of clipping planes were added. - lmk if u want me to leave it this way and i can update the comment properly - or lmk if there's anything specific u want me to do here.