Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC-DRY] Use anonymous function where applicable #669

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 21, 2013

refs https://groups.google.com/d/msg/cesium-dev/nm-QWU5sppI/VeA4GmJtC6kJ

This PR replaces var X = function X(){}; by var X = function(params) {};

The only reason why the old syntax could be usefull is when displaying a call stack (to see the function name rather than "anonymous function". I don't expect this this to be really frequent as modified functions are mainly constructor.

The benefit are:

  • shorter / simpler code,
  • consistency (both syntax were in use).

@mramato
Copy link
Member

mramato commented Jul 26, 2013

Since the general consensus seems to be to do #676 instead of this, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants