Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clamping when switching terrain providers #6820

Merged
merged 3 commits into from Jul 19, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jul 19, 2018

Fixes #6818

If the tile wasn't loaded yet tile.data.pick would return undefined and data.callback wasn't called. However, we were still setting data.level to the new tile level so on the next frame this whole block was skipped because it thinks it was already called for this LOD. Moving data.level = tile.level into the block where data.callback is called assures that data.level matches the level the callback was called for.

@cesium-concierge
Copy link

cesium-concierge commented Jul 19, 2018

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@bagnell
Copy link
Contributor

bagnell commented Jul 19, 2018

👍

@bagnell bagnell merged commit 943fe93 into master Jul 19, 2018
@bagnell bagnell deleted the fix-height-callback branch July 19, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants