sampleHeight fixes and cleanup #7174
Conversation
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| @@ -3112,10 +3112,19 @@ define([ | |||
| this._lastRenderTime = JulianDate.clone(time, this._lastRenderTime); | |||
| this._renderRequested = false; | |||
| this._logDepthBufferDirty = false; | |||
| var frameNumber = CesiumMath.incrementWrap(frameState.frameNumber, 15000000.0, 1.0); | |||
| updateFrameNumber(this, frameNumber, time); | |||
There was a problem hiding this comment.
Separated updateFrameState and updateFrameNumber so that the frame number/time can be updated before update. In #7115 update is where async tiles get loaded so the frame number needs to be correct for the tileset cache to work properly.
lilleyse
force-pushed
the
offscreen-picking-prep
branch
from
ebd65d9
to
4b3bfbf
Compare
Source/Core/Ray.js
Outdated
| if (!defined(result)) { | ||
| return new Ray(ray.origin, ray.direction); | ||
| } | ||
| result.origin = ray.origin; |
There was a problem hiding this comment.
Here and below should clone ray.origin and ray.direction.
|
Those are the only comments. Looks good to me. |
|
@bagnell Thanks, updated. |
|
I have code like,three entities, a gltfModel and with polyline and label on top of the polyline. I have been using sampleHeight(), to find the height of the gltfModel. but it didn't work as expected. Is there any other method to do that. Or what to do in this? Thank You |
Fixes #7120 and #7129
Otherwise most of this is organizational changes from #7115 that will make that PR easier to review later.
@bagnell can you review?