Rename speedup to multiplier #7393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Changes look good to me! Should it maybe be named just |
|
I was worried multiplier on its own might be confused with something about how many times the animation loops but I could just be paranoid. I'm open to suggestions. |
|
Just |
|
Should be good now @lilleyse ! |
lilleyse
changed the title
|
Cool, thanks! |
|
@OmarShehata make sure to open an issue to remove the deprecated functionality in 1.54. Someone can then assign it the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion here: #7361 (comment)
This renames
ModelAnimation.speeduptoModelAnimation.timeMultiplierand adds a deprecation warning that it will be removed in one more version. I kept the old property and added a@deprecateddoc tag. I also tweaked the doc HTML slightly to make sure there's a newline after the deprecated statement so that it looks better.I was initially going to just call it
ModelAnimation.ratebut that felt like it was referring to "Frame rate" but glTF animations are based on real time, not a fixed frame rate. I thought aboutscaleortimeScalebut just went withtimeMultiplierbecause I it made the most sense to me.@hpinkos @lilleyse do either of you want to review?