Fix IDL intersection of rhumb lines by using the correct sign of PI #7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shehzan10
force-pushed
the
rhumb-line-IDL-intersection-fix
branch
from
935d17f
to
a4eb129
Compare
|
This can also be tested using the |
|
Thanks for the pull request @shehzan10!
Reviewers, don't forget to make sure that:
|
likangning93
reviewed
Feb 7, 2019
There was a problem hiding this comment.
@shehzan10 just the one comment, otherwise this looks good. Thanks!
|
@likangning93 Updated. |
|
Thanks @shehzan10! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the intersection depended on which sign of PI was being used, and as a result of rhumb lines being spirals, a non-first latitude was being returned.
Added a spec to ensure this.
@likangning93 would you do the honors?