Billboard 2D pick fix #7908
Merged
Billboard 2D pick fix #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for billboards in zoomed out 2D View
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
|
Can confirm this fixes the issue - thanks for the speedy fix @lilleyse ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7868
A small mistake in #7434 caused billboards not to be pickable when zoomed out in 2D view. At the zoomed out view the scene renders the globe in two sections and the viewer/scissor were not getting accounted for in
GlobeDepth.Note the diff around here https://github.com/AnalyticalGraphicsInc/cesium/pull/7434/files#diff-c0134c9a4ab93c317c6e68303fd7ff00R293. The line
globeDepth._copyColorCommand.renderState = globeDepth._rs;was accidentally removed.