Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babylon previewer: "script error" #152

Closed
tkazik opened this issue Feb 7, 2019 · 8 comments
Closed

Babylon previewer: "script error" #152

tkazik opened this issue Feb 7, 2019 · 8 comments

Comments

@tkazik
Copy link

tkazik commented Feb 7, 2019

Hi folks

First of all: Congrats to your awesome work...I really appreciate it!
I recently ran into the following issue with the babylon previewer:
vscode_gltf_tool_babylon_error
The other two viewers display the model correctly and also babylon's online sandcastle is able to show the model, thus I think this issue might be related to this gltf-tool.

I am using the latest version (2.2.2) and the model (contains one info level issue by validator) can be found here:
G6000_strut.zip

Thank you for any insight!

@emackey
Copy link
Member

emackey commented Feb 7, 2019

@tkazik Did you just upgrade to VSCode 1.30.0 prior to this?

I just got the upgrade and I'm seeing this error now on my own models. Looks like the BabylonJS logo is causing a CORS error. I'll see what else I can figure out about it.

/cc @bghgary

@bghgary
Copy link
Contributor

bghgary commented Feb 7, 2019

I'm investigating

@bghgary
Copy link
Contributor

bghgary commented Feb 7, 2019

Looks like the new vscode broke a bunch of things. I'll see if I can fix them, but it might take some time.

@bghgary
Copy link
Contributor

bghgary commented Feb 7, 2019

We might have to ask vscode folks on this. I can't explain why the svg logo and blob urls to local data are being blocked.

@bghgary
Copy link
Contributor

bghgary commented Feb 8, 2019

For now, if you want this to work, please downgrade back to 1.30.

@emackey
Copy link
Member

emackey commented Feb 9, 2019

@bghgary Thanks for your efforts tracking this down! I see a PR was merged into Babylon.

Random question, why is revokeObjectURL needed? As a hack I tried resetting this to an empty function, and that seems to work in VSCode. Is it still needed? Does it free resources or memory?

@bghgary
Copy link
Contributor

bghgary commented Feb 10, 2019

Does it free resources or memory?

Yes. See https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL#Memory_management.

@emackey
Copy link
Member

emackey commented Feb 12, 2019

Version 2.2.3 is published! Thanks @bghgary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants