Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minSdk lower in android library #4

Closed
dant3 opened this issue Feb 4, 2022 · 2 comments
Closed

Make minSdk lower in android library #4

dant3 opened this issue Feb 4, 2022 · 2 comments

Comments

@dant3
Copy link

dant3 commented Feb 4, 2022

minSdk = 26 covers 80% of the devices according to play market stats. While it might work for some projects, it will not work for others. Is there a specific reason why it has to be 26? Looking at the code, I guess it can be easily lowered to something like 21 which would make this library easier to use.

Currently you have to add a pesky

    <uses-sdk
        android:minSdkVersion="24"
        tools:overrideLibrary="dev.reformator.stacktracedecoroutinator"
        />

in order to use this library in android project which needs lower minSdk

@Anamorphosee
Copy link
Owner

minSdkVersion was made 26 for a reason:
Classes that the SD generates use the MethodHandles API, which requires API 26.

It's possible not to use MethodHandles, but it will require significantly more generated classes.

@dant3
Copy link
Author

dant3 commented Feb 4, 2022

Alright. So it means you can't get away with the override, which makes #2 even more valuable then.

@Anamorphosee Anamorphosee closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants