-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Genbook improvement: display footnotes #689
Comments
I believe this is fixed by now. @timbze you can confirm and re-open if not. |
Also, first Baptist confession 1646 has x-editor-correction tags which are notes that have not been implemented. E.g. See section 40 |
I don't know what magic Xiphos does, but osis XML fragment does not mark these in any way so what can we do? It's like this there:
|
I'm guessing jsword doesn't handle the case correctly. My OP shows what the source file has, so probably libsword handles it better. |
I believe it's not OSIS source and we don't support non-OSIS sources very well. |
Fixed footnote issue 9e1c201 (x-editor-correction) |
Need to modify jsword to give fragments of (whatever-xml) and render it in js side (should be easy now) |
Hmm, it has SourceType OSIS |
Chapter 1 seem to be invalid XML org.jdom2.input.JDOMParseException: Error on line 77: At line 77, column 2: mismatched tag |
Invalid OSIS there...
|
Module issue it is then. |
There are also 6 other XML errors that match the regexp pattern |
Could you @timbze or @DavidHaslam report this module issue to Crosswire tracker. I guess it's practice @ crosswire these days to check osis xml through lint?
|
CrossWire probably doesn't have the original OSIS XML file that the module was made from. cf. My only tweaks in 2020 were just to the .conf file. |
It seems that Genbook does not display footnote
<note>
tags.For example, Xiphos shows *n1, *n2, etc in Chapter 1 of 1689 London Baptist Confession genbook. But AB does not show anything where those footnotes are.
Xiphos:
Chapter 1 *n1 code in genbook .bdt file looks like this:
The text was updated successfully, but these errors were encountered: