Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push to CRAN #7

Open
AndreaCirilloAC opened this issue Mar 22, 2017 · 9 comments
Open

push to CRAN #7

AndreaCirilloAC opened this issue Mar 22, 2017 · 9 comments

Comments

@AndreaCirilloAC
Copy link
Owner

@RobertMyles as you previously suggested I think this useful package is now ready to be submitted to CRAN.
What do you think about it?

@RobertMyles
Copy link
Contributor

I think it's good to go, Andrea! Maybe we could run some checks with the devtools package before we submit it, but other than that I think it's good to go :-)

@AndreaCirilloAC
Copy link
Owner Author

I run the devtools check on the package. everything went smoothly except for the following error:

* checking package dependencies ... ERROR
Namespace dependency not required: ‘magrittr’

See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.
* DONE
Status: 1 ERROR
checking package dependencies ... ERROR
Namespace dependency not required: ‘magrittr’

going to look into this.

@RobertMyles
Copy link
Contributor

Ah, it must be the line "@importFrom magrittr '%>%' "; it appears to be unnecessary; my mistake!

@AndreaCirilloAC
Copy link
Owner Author

AndreaCirilloAC commented Mar 28, 2017 via email

@RobertMyles
Copy link
Contributor

Yeah, that's a strange one. We use the pipe, so I think it's better to explicitly import it, and I'm not sure why the check would throw an error like that. Looking at the code, I think we should probably also change the example to a "Not run" example. Perhaps we could try changing back to importing dplyr instead of magrittr and see if it throws this error?

@RobertMyles
Copy link
Contributor

Hi Andrea, I just pushed a commit that should fix some of these problems. I didn't change the example, maybe you might like to do that, but it is pretty much ready to go to CRAN.

@AndreaCirilloAC
Copy link
Owner Author

thank you @RobertMyles , just submitted.
going to wait for their review for (hopefully) closing the issue.
schermata 2017-04-04 alle 05 11 17

@AndreaCirilloAC
Copy link
Owner Author

nearly done, but still not there, got the following two errors from pre-test:

  • checking examples ...
    ** running examples for arch 'i386' ... ERROR
    Error: .Platform$OS.type == "unix" is not TRUE
    Execution halted
    ** running examples for arch 'x64' ... ERROR

full log at:https://win-builder.r-project.org/incoming_pretest/170404_051110_updateR_01/00check.log

this is due to platform limitation I guess. going to look how to overcome this, which I think is possible since packages like our inspiration InstallR from Tal Galili are for Windows only.

@AndreaCirilloAC
Copy link
Owner Author

added os_type on description with fad7ff3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants