-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory usage with fs.createReadStream() #17
Comments
Side question: which tool are you using to analyse memory usage in Node? |
I just wrote something simple: 7e5496a maybe I will make a real module some day :D |
7b91e4a should fix this. If you try it out (please do) be aware that you will need at least node version 5.2.0 for now. However I have been promised that the necessary node features will land soon in 4.x. |
I don't get why this is an issue. I suspect it might be a v8 bug in the gc, 7b91e4a basically just moved the stack object into an id-map and does the memory management itself. For future reference I also tried using a WeekMap, so I din't have to use the gc destroy event, there was an improvement but not enough. |
Thanks for creating the issue. I really appreciate the time you use on |
Glad to help. Thanks for your work :) |
It seems that the entire file is loaded in memory.
The text was updated successfully, but these errors were encountered: