Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing textures for BetterEnd/BetterNether slabs #13

Open
muon-rw opened this issue Aug 19, 2023 · 7 comments
Open

Missing textures for BetterEnd/BetterNether slabs #13

muon-rw opened this issue Aug 19, 2023 · 7 comments

Comments

@muon-rw
Copy link

muon-rw commented Aug 19, 2023

We briefly discussed this on Discord, just submitting an issue for tracking.

Better-End-2.1.6
Better-Nether-7.1.4
AutoSlabs-1.1.0

Place any BCLib slab vertically and the texture will be missing.

@Siyanochka
Copy link

Same on newer versions
better-end-4.0.10
better-nether-9.0.9
autoslabs-1.1.2

@MetaForge
Copy link

Just got the same problem with betterend and missing textures when using auto-slabs :/

@Andrew6rant
Copy link
Owner

This issue is due to the way BetterEnd and BetterNether set up their slab models. It can be fixed if they define slab models like Vanilla (using bottom, side, and top as texture definitions), or by user-made resource pack.

Here is a commit of mine that adds texture and model support to Mo Glass' glass slab: b33cd4b. You can see how I set up the model JSONs, and do pretty much the same thing for these slabs.

I'm not going to add support for these or the rest of BCLib's slabs (not now, at least), so if you want them in AutoSlabs, feel free to make a PR.

@MetaForge
Copy link

MetaForge commented Aug 29, 2023

Thanks for the explanation and the example. If i've understood correctly, you are saying that the order in which bottom, side and top are defined in the model json is incorrect? If so it seems simple enough that I would try to fix it myself, but when i searched through the betterend json files i cant even find all the slab json files... is there something i am missing?

@Gamemassa
Copy link

I'm having this issue as well. So just to be clear, should this issue be reposted in the BCLib team's GitHub?

@Gamemassa
Copy link

Gamemassa commented Sep 9, 2023

@Andrew6rant Oh also, not sure if it's the same bug, but I'm noticing that slabs from Terraqueous also don't display textures correctly when placed vertically. (If it's not, I can certainly move that to its own thread instead)

@Gamemassa
Copy link

@Andrew6rant So I just heard back from Paulevs from the BetterX team, and he said that you should be able to pull block textures directly from the block model instead of from the JSON. Not sure if that'll help you, but at least I've got the ball rolling to some extent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants