Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CFBundleVersion in Bluebird_Info.plist #7

Merged
merged 1 commit into from Apr 1, 2020
Merged

Correct CFBundleVersion in Bluebird_Info.plist #7

merged 1 commit into from Apr 1, 2020

Conversation

mattrobmattrob
Copy link
Contributor

This fixes #6, which was causing an ITMS error when Carthage referenced Bluebird.framework is copied into App.app/Frameworks/Bluebird.framework due to having a missing CFBundleVersion key.

It was previously missing because it referenced an un-set CURRENT_PROJECT_VERSION build setting.

Testing:

$ carthage build --no-skip-current
*** xcodebuild output can be found in /var/folders/4y/7k0ckw7n69v9bgsvt6x7bnrc0000gn/T/carthage-xcodebuild.AEJZJ5.log
*** Building scheme "Bluebird-Package" in Bluebird.xcodeproj

$ plutil -convert xml1 Carthage/Build/iOS/Bluebird.framework/Info.plist -o ~/Desktop/Bluebird_Info.plist

$ grep "CFBundleVersion" ~/Desktop/Bluebird_Info.plist
	<key>CFBundleVersion</key>

$

Built inside app using this branch:

Framework Bundle Info.plist
Screen Shot 2020-04-01 at 12 13 05 PM Screen Shot 2020-04-01 at 12 13 13 PM

Fixes #6.

@mattrobmattrob
Add CFBundleVersion to Bluebird_Info.plist
8864d06 
This fixes AndrewBarba#6, which was causing an ITMS error when `Bluebird.framework` is copied into `App.app/Frameworks/Bluebird.framework` due to having a missing `CFBundleVersion` key.

It was previously missing because it referenced an un-set `CURRENT_PROJECT_VERSION` build setting.

**Before:**
```
~/Developer/github/AndrewBarba/Bluebird.swift · (master±)
⟩ cat Carthage/Build/iOS/Bluebird.framework/Info.plist | grep "BundleVersion"
~/Developer/github/AndrewBarba/Bluebird.swift · (master±)
```
**After:**
```
~/Developer/github/AndrewBarba/Bluebird.swift · (master±)
⟩ cat Carthage/Build/iOS/Bluebird.framework/Info.plist | grep "BundleVersion"
Binary file (standard input) matches
```
@mattrobmattrob mattrobmattrob changed the title Add CFBundleVersion to Bluebird_Info.plist Correct CFBundleVersion in Bluebird_Info.plist Apr 1, 2020
@AndrewBarba
Copy link
Owner

Awesome thank you

@AndrewBarba AndrewBarba merged commit 91d52a0 into AndrewBarba:master Apr 1, 2020
@mattrobmattrob mattrobmattrob deleted the mr/bluebird/6 branch April 1, 2020 18:47
@mattrobmattrob mattrobmattrob restored the mr/bluebird/6 branch April 1, 2020 18:47
@devioustree devioustree mentioned this pull request Apr 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carthage Bluebird.swift framework is missing CFBundleVersion
2 participants
@mattrobmattrob @AndrewBarba