Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Django < 1.6 'fields' handling #114

Closed
jonashaag opened this issue Dec 7, 2015 · 0 comments
Closed

Remove Django < 1.6 'fields' handling #114

jonashaag opened this issue Dec 7, 2015 · 0 comments

Comments

@jonashaag
Copy link
Collaborator

In ModelFormSetMixin and BaseInlineFormSetMixin, remove the code that overwrites self.fields if Django >= 1.6 entirely and let Django handle it.

This breaks django-extra-view backwards compatibility, but the introduction of mandatory fields was backwards-incompatible in Django too, and we should rather stick with the new behavior introduced by Django rather than keep Django's old behavior forever. (It was changed in Django for good reasons, namely security.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant