kernel: Implement a syscall proc macro #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a procedural macro that takes care of validating input buffers and paths automagically for us :^) There is still a bit of clean up/bug fixing to do, but for the most part it does what it's supposed to be doing.
|
When you state |
Oh my bad, it's just that I was in the middle of writing the PR message when I realized what was causing the proc macro to panic when emitting the code for &Path and I fixed it without realizing I left the comment there 😅 Edit: fixed! |
* The current code parsed the array by parsing it as a slice and then getting a reference `N` elements which does *not* make it an array (it will still be a slice). * Update the macro to use `validate_array_mut` to validate and construct the array. * Remove the length param from ArgType::Array since the `validate_array_mut` method takes the length as a const generic param which means that the compiler can automagically get us the length :^) * Remove all of the useless diagnostic since now we automagically get the array length. Signed-off-by: Andy-Python-Programmer <andypythonappdeveloper@gmail.com>
Signed-off-by: Andy-Python-Programmer <andypythonappdeveloper@gmail.com>
Signed-off-by: Andy-Python-Programmer <andypythonappdeveloper@gmail.com>
|
Thanks @czapek1337! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a procedural macro that takes care of validating input buffers and paths automagically for us :^) There is still a bit of clean up to do, but for the most part it does what it's supposed to be doing.