Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - allow to define notification filter #17

Open
weilbith opened this issue Nov 19, 2020 · 7 comments
Open

Feature Request - allow to define notification filter #17

weilbith opened this issue Nov 19, 2020 · 7 comments

Comments

@weilbith
Copy link

Hey 馃憢

First, thank you very much for this cool browser add-on! 馃檹

The "new" notification system of GitHub allows to define permanent filters. These save my day when I'm actually working over the day to have list with relevant notifications for my repos of the company. Unfortunately I still get notified by this add-on about all notifications I receive. This can become really annoying while doing your work and leads to ignore these notifications and thereby miss the relevant ones for work.
So I would love to ask if you could add a simple configuration option that allows to specify such a filter with a query as GitHub uses it. That would be really awesome! I'm thankful for any feedback.

@AngelFQC
Copy link
Owner

So I would love to ask if you could add a simple configuration option that allows to specify such a filter with a query as GitHub uses it. That would be really awesome! I'm thankful for any feedback.

Yes, I will review this weekend

@weilbith
Copy link
Author

Any results already? Did I missed something? 馃

@AngelFQC
Copy link
Owner

AngelFQC commented Dec 6, 2020

Hi @weilbith

I can't find a method to filter notifications from GitHub API. But there's a endpoint to get notifications from one repository https://docs.github.com/en/free-pro-team@latest/rest/reference/activity#list-repository-notifications-for-the-authenticated-user

So, I can add one configuration option, but the call to GitHub API will make one request for one repository.

Or I can get all global notifications (current endpoint) and filter the notifications coming from the repositories what you set in the configuration option

@weilbith
Copy link
Author

weilbith commented Dec 7, 2020

Hmm. Do you eventually have access to the already created filters of a user? 馃

@AngelFQC
Copy link
Owner

AngelFQC commented Dec 7, 2020

Hmm. Do you eventually have access to the already created filters of a user? thinking

No. I will try other possible ways to do it

@weilbith
Copy link
Author

weilbith commented Dec 8, 2020

Thank you! 馃檭

@weilbith
Copy link
Author

weilbith commented Mar 1, 2021

@AngelFQC was there any progress? Is this not possible?

@weilbith weilbith removed their assignment Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants