Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show notification when count is decreased #4

Closed
umpirsky opened this issue Jan 18, 2018 · 6 comments
Closed

Do not show notification when count is decreased #4

umpirsky opened this issue Jan 18, 2018 · 6 comments

Comments

@umpirsky
Copy link
Contributor

Scenario:

  1. You have 4 notifications.
  2. You read one.
  3. You get notification that you have 3 notifications.

This is not related to count badge, but popup notifications.

@umpirsky
Copy link
Contributor Author

umpirsky commented Feb 6, 2018

@AngelFQC This still happens, can you reopen please?

@AngelFQC
Copy link
Owner

AngelFQC commented Feb 6, 2018

This is the default behaviour
You need uncheck the "Show desktop notifications when decreasing count" in Preferences
captura el 2018-02-06 a las 09 13 32

@umpirsky
Copy link
Contributor Author

umpirsky commented Feb 6, 2018

@AngelFQC Clear, thanks. Do you think it makes sense to make this default?

@AngelFQC
Copy link
Owner

AngelFQC commented Feb 6, 2018

@umpirsky Because that was the behavior of the previous version

@umpirsky
Copy link
Contributor Author

umpirsky commented Feb 6, 2018

@AngelFQC But it was a bug, not a feature, right? :)

@AngelFQC
Copy link
Owner

AngelFQC commented Feb 6, 2018

Not for me, I receive many notifications every day (maybe 10 on average)

You have 4 notifications, you read 2 (quickly, a matter of seconds), then you have 2 in github but 4 in the badge (it is updated every 60 seconds), you may receive 1 more notification, then you have 3, 60 seconds pass, the badge is updated, you would have 2 old notifications and 1 new one. 3 < 4, then showing the notification would make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants