Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from twitter #1

Closed
6 tasks done
AngelMunoz opened this issue Nov 23, 2020 · 3 comments
Closed
6 tasks done

Feedback from twitter #1

AngelMunoz opened this issue Nov 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@AngelMunoz
Copy link
Owner

AngelMunoz commented Nov 23, 2020

I took a few notes from Twitter earlier today

  • look a way to create indexes
  • remove prefixes from custom operations
  • pass the collection name as the parameter of the CE's
  • return typed results from the command execution
  • add BSON decoders
  • add method helpers to create things like filters, fields, matching criteria
@AngelMunoz AngelMunoz added the enhancement New feature or request label Nov 23, 2020
@AngelMunoz AngelMunoz self-assigned this Nov 23, 2020
@AngelMunoz
Copy link
Owner Author

all of these have their own issue now, so I will close this

@Alkasai
Copy link

Alkasai commented Nov 23, 2020

I like the new typed results!
What do you think about wrapping this into some sort of function that just returns seq of type User, instead of coursor?

let result = db.RunCommand<FindResult<User>>(JsonCommand over20)
printfn $"FindResult Ok: %f{result.ok}"
result.cursor.firstBatch |> Seq.iter (fun value -> printfn $"%A{value}")

@AngelMunoz
Copy link
Owner Author

@Alkasai we can review any kind of helper function as part of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants