Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static files directories #33

Closed
AngelMunoz opened this issue Oct 3, 2021 · 0 comments · Fixed by #39
Closed

Fix static files directories #33

AngelMunoz opened this issue Oct 3, 2021 · 0 comments · Fixed by #39
Labels
bug Something isn't working in-dev The item has been worked and can be found in the dev branch

Comments

@AngelMunoz
Copy link
Owner

Describe the bug
importing a json file from the indx file converts the file in a json module, we need to find a way to apply middleware or not

To Reproduce
Steps to reproduce the behavior:
add this to an index.html file

<link rel="manifest" href="./src/manifest.json" />

Expected behavior
sent the json file as json, not as a JS module

maybe using a query param like unpkg?

  • ./src/manifest.json?module should return a JS module
  • and ./src/manifest.json should return the file as is
@AngelMunoz AngelMunoz added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 3, 2021
@AngelMunoz AngelMunoz pinned this issue Oct 3, 2021
@AngelMunoz AngelMunoz added in-dev The item has been worked and can be found in the dev branch and removed help wanted Extra attention is needed good first issue Good for newcomers labels Oct 10, 2021
@AngelMunoz AngelMunoz unpinned this issue Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-dev The item has been worked and can be found in the dev branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant