-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong Version Jinit requested #66
Comments
@FlorianRappl |
Yes, but so far a lot of internal things changed. So my intention was to change to 3.0.0 once available. But I'm happy to have another look at the last 2.x version, too - if really urgent. |
I probably could have a look at this at some point. This seems like an interesting case of integrating the engine and 3.x series of Jint indeed has tons more functionality and fixes. |
Fully agreed @lahma ! |
I've created a PR on Jint side which tries to build better support for your use case, basically ability to have custom I'll use AngleSharp.Js as guinea pig for testing the API and possibilities. This might take some time before completion as it's only a side projects among many others... |
That sounds really great. I'd love to help you there. Is there something I can do out of the box (can also be some stories that are left to pick up at Jint's side; maybe I can get into that project a bit)? Thanks for everything @lahma ! 🍻 |
If you have usage stories about what is currently missing/impossible that would of course help. At this first stage I'm trying to build the current functionality on top of this new host/realm concept and everything that might affect API + needed functionality will always help. |
Probably best scenario is emulate a real "chrome" browser need to add missing class on anglesharp.js (navigator, history, window) not need real behaviour just emulation to bypass javascript scripts |
We have this in most parts. The largest missing part is the layouting API, which is also hard to emulate (we can always spit out some values here, but usually the JS libs that call these APIs have some constraints in mind and wouldn't be tricked so easily). |
We've also improved c# interop quite a lot so at times might help to expose plain object instance too (and then open a lot of bugs when things go wrong). |
just example of some test that you can check that not work as should be (compared with chrome results), other user case is bypass akam (https://github.com/OXDBXKXO/akamai-toolkit/blob/master/scripts/akamai-1.68-nike.js)
|
Well, you use WebGL and Canvas. As I wrote @bbday layouting APIs are not implemented. Would be good if you read / understand first what I wrote. Its not about window, navigator or such APIs, but really about these painting mechanisms. This will also not change overall, as AngleSharp is just a browser core and not a browser. |
That's great @lahma, but the issue will be that names are different. We use special attributes to derive the official name (most are straight forward though, e.g., |
Thanks for the insights, plug-and-play name matcher has been a request before (whether to allow matching with first-lower or not) so this is a good reminder that there should be option to define such matcher strategy with ability to write the logic however wanted. |
Just and update after some hibernation, I haven't forgotten this issue, there's just a lot to do in this world. So far I've tried some migration and opened some PRs to improve the interop story, AngleSharp.JS brilliant this way that it's true interop in JS sense.
So this will definitely take some time, but I think ideally we can get Jint to a point where most things are built-in and needed customizations shouldn't be too hard to provide. |
This is superb - thanks for the update @lahma ! Much appreciated! |
Latest Jint in preview of the 1.0.0 now. |
when try to loading Configuration.Default.WithJs() on .net core 3.1 it will say "Could not load file or assembly" jinit Version = 2.10.4.0 ... The located assembly's manifest definition dose not match the assembly reference.
Atm is installed Jinit 2.11.58 on system (it installed by it self when installed AngleSharp.Js from nuget)
The text was updated successfully, but these errors were encountered: