-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module parse failed #399
Comments
https://github.com/AngularClass/angular2-webpack-starter/blob/master/webpack.config.js#L55 |
Wow that was the fastest reply I've ever gotten :D Could you explain what the purpose is of |
the angular2-moment module is exposing the typescript files directly when it should only be the js files. because of this you need to make sure the typescript loader can see the files (because I excluded them) which means you take a small perf hit now that the typescript loader needs to parse all .ts files in node_modules |
Thanks man ! |
@gdi2290 do you have any other examples of TypeScript modules which only expose the js files? I am trying to find whether there is any kind of best practice. @cschroeter another solution that could work would be to implicitly reference the js file in your code:
|
i have experienced a similar issue to #402 attempting to load css into the App component from ng2-toasty in node_modules, and can work around it by removing node_modules from the exclude array of the css loader, but i realize this causes performance issues and probably is not an optimal production solution. Does anyone have an idea of how I should be attempting to load css from node_modules correctly so that I could still exclude node_modules in the css loader? Do I need to load the css from the assets directory instead? |
@gdi2290 could you please point to a recent version of webpack config file with the offending line? Or maybe fix the link with the version at that time? Thank you! |
Since a few days this starter project comes up with an error message after I've installed angular2-moment.
What I did?
Do you have any idea what the problem could be?
The text was updated successfully, but these errors were encountered: