Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Angular2 RC7 dependency warning #998

Merged
merged 3 commits into from Sep 17, 2016
Merged

fix: Angular2 RC7 dependency warning #998

merged 3 commits into from Sep 17, 2016

Conversation

Simon-Briggs
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix for issue #993

  • What is the current behavior? (You can also link to an open issue here)

Warning in webpack during build

  • What is the new behavior (if this is a feature change)?

No Warning

  • Other information:

@PatrickJS PatrickJS merged commit 68e796f into PatrickJS:master Sep 17, 2016
@PatrickJS
Copy link
Owner

thanks

@sbolel sbolel mentioned this pull request Sep 20, 2016
Closed
awcodify pushed a commit to awcodify/d3-angular-4 that referenced this pull request Aug 28, 2017
@Simon-Briggs @PatrickJS
fix: Angular2 dependency warning (PatrickJS#998)
654d582 
* fix: Angular2 RC7 dependency warning

* ~ minor syntactic change

LGTM

* Update webpack.common.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Simon-Briggs @PatrickJS @katallaxie