Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle importing files with ProxyShapes #33

Open
alekamca opened this issue Dec 7, 2017 · 1 comment
Open

Handle importing files with ProxyShapes #33

alekamca opened this issue Dec 7, 2017 · 1 comment

Comments

@alekamca
Copy link
Contributor

alekamca commented Dec 7, 2017

Does it make sense to disable executing the post load process when importing in files? I.e., change https://github.com/AnimalLogic/AL_USDMaya/blob/master/lib/AL_USDMaya/AL/usdmaya/nodes/ProxyShape.cpp#L1099

to
if(m_stage && !MFileIO::isOpeningFile() && !MFileIO::isImportingFile() )

@alekamca alekamca changed the title Disable ProxyShapePostLoadProcess when importing/referencing in file Handle importing files with ProxyShapes Dec 7, 2017
@alekamca
Copy link
Contributor Author

alekamca commented Dec 7, 2017

While digging into this more, I've discovered that simply changing that one line isn't sufficient to fully support importing files with ProxyShapes. At the very least, the postFileOpen callback needs to also be called postFileImport. However, in this case, we don't want to mess up any previously existing ProxyShapes by trying to re-initialise them.

I'm working on handling this case now, but it will probably be a bit before I have it working in a general enough way that it's fully tested and ready for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant