Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Talks are not rolling back with a dungeon failure #92

Open
scooterboo opened this issue Feb 10, 2024 · 1 comment
Open

[Bug] Talks are not rolling back with a dungeon failure #92

scooterboo opened this issue Feb 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@scooterboo
Copy link

Describe the bug
When going through Chasing Shadows after failing the quest and doing some talks, the talks do not get rolled back. When you talk to someone you have already talked to, the conversation instantly completes.

How to replicate:
Do Chasing Shadows and talk to people. If you exit the dungeon and re-enter, notice how the talks go different.

Notes:
Check out https://github.com/Grasscutters/Grasscutter/blob/6e1913aacb96473ab24027cee54d3fa806034f2c/src/main/java/emu/grasscutter/game/quest/GameQuest.java#L186
This little piece of code rolls back the talks when rollback is called.
Putting this line of code in fixes the issue.

Which branch did you use?
multi_proto
Grasscutter version: 1.4.4-dev-59e2d2b4
Lua: JNLua

Screenshots

talk.mp4
@scooterboo scooterboo added the bug Something isn't working label Feb 10, 2024
@scooterboo
Copy link
Author

A similar thing is happening with player progress. All of the resetCurrentProgress in clearProgress need to be ported over as well.

This is causing you to get the key early since the QUEST_CONTENT_ADD_QUEST_PROGRESS in 2010140 is not being rolled back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant