Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with parsing ens #1

Closed
iainnash opened this issue Dec 20, 2021 · 1 comment
Closed

Issues with parsing ens #1

iainnash opened this issue Dec 20, 2021 · 1 comment

Comments

@iainnash
Copy link

iainnash commented Dec 20, 2021

Hey! I've integrated a fork of this library into https://github.com/iainnash/ens2airdrop ens2airdrop and found some issues with it:

  1. .Eth is not recognized: changed the ens regex to support case insensitive matches
  2. people incorrectly uppercase ens names, so it does a search for both the exact case and lowercase versions
  3. Regex for detecting ens names doesn't handle cases where the name is unicode or non-ascii.
  4. Invalid addresses are still added to the result if they follow any sort of 0xNNN format, added in an ethers isAddress(str) check to determine if invalid/valid.

These all are fixed in the forked scraper https://github.com/iainnash/ens2airdrop/blob/main/scraper/scraper.ts here.

@Anish-Agnihotri
Copy link
Owner

Thank you boss, merged in #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants