Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

HammadKhaan
Copy link

@HammadKhaan HammadKhaan commented Oct 17, 2022

Dark Mode feature implemented as requested in #18

dark-mode.mp4

@vercel
Copy link

vercel bot commented Oct 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devmate ✅ Ready (Inspect) Visit Preview Oct 17, 2022 at 1:52PM (UTC)

@HammadKhaan
Copy link
Author

@AnkitaMalik22 Kindly review my PR, and merge it.

@AnkitaMalik22
Copy link
Owner

AnkitaMalik22 commented Oct 18, 2022

@AnkitaMalik22 Kindly review my PR, and merge it.

You need to do some changes

  • add dark / light mode icon instead of writing it.
  • it doesn't work when someone use chrome dark mode already

Screenshot_20221018-161259.png

@HammadKhaan
Copy link
Author

@AnkitaMalik22 Kindly review my PR, and merge it.

You need to do some changes

  • add dark / light mode icon instead of writing it.
  • it doesn't work when someone use chrome dark mode already

Sure, I am on it.

@AnkitaMalik22
Copy link
Owner

@AnkitaMalik22 Kindly review my PR, and merge it.

You need to do some changes

  • add dark / light mode icon instead of writing it.
  • it doesn't work when someone use chrome dark mode already

Sure, I am on it.

& The dark mode should look like this

Screenshot_20221018-162519.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants