Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate shell completion scripts rather than manually maintaining them #2

Open
2 tasks
Anomalocaridid opened this issue Apr 6, 2022 · 1 comment
Open
2 tasks
Labels
enhancement New feature or request waiting-on-upstream Cannot be resolved until a change is made in an upstream repository

Comments

@Anomalocaridid
Copy link
Owner

Anomalocaridid commented Apr 6, 2022

Generate shell completion scripts using clap_complete. This would make it easier to keep the completion scripts up to date with any changes to handlr's arguments as well as support other shells.

Ideally, a solution should use build.rs or cargo xtask and leverage the existing Cmd struct.

To do:

  • Implement completion generation in cargo xtask
  • Update GitHub Actions
@Anomalocaridid Anomalocaridid added the enhancement New feature or request label Apr 6, 2022
@Anomalocaridid
Copy link
Owner Author

Since handlr-regex relies on a hidden subcommand being run by completion scripts in order to have dynamic completion with mimetypes, file extensions, and desktop files of installed programs, this may not be feasible until clap-rs/clap#1232 has been resolved.

@Anomalocaridid Anomalocaridid modified the milestone: 0.8.0 Jul 23, 2022
@Anomalocaridid Anomalocaridid added the waiting-on-upstream Cannot be resolved until a change is made in an upstream repository label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting-on-upstream Cannot be resolved until a change is made in an upstream repository
Projects
None yet
Development

No branches or pull requests

1 participant