Minor improvements across render styles #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add: Added tests for the workaround. - Change: Moved `_is_on_kitty()` from `BlockImage` to `TextImage`. - Change: Reduced function calls. - Change: Only the red band is modified to reduced the amount of possible comparisons.
AnonymouX47
added
lib
AnonymouX47
force-pushed
the
render-style-updates
branch
from
7d6002a
to
ac0f40f
Compare
- Change: Now explicitly testing multiple colors and `None` (no query response). - Change: No longer terminal-dependent.
- Add: Added `_TERM` and `_TERM_VERSION` to `KittyImage`. - Change: Removed `KittyImage._KONSOLE_VERSION` since it's unused. - Change: Modified `KittyImage.is_supported()`. - Konsole is now always supported as long as it responds to the graphics query. - Change: Improved buffer handling in `Iterm2Image._render_image()` and `.kitty.Transmission.get_chunks()`. - Change: Cleaned up `KittyImage._render_image()`. - Removed `else` after an early return. - Removed unnecessary `dict` instantiation. - Change: Refactored code for style attribute export and import in `.logging_multi.Process`.
- Add: Added a `clear()` method to each of `KittyImage` and `Iterm2Image`. - Added `.image.kitty.DELETE_CURSOR_IMAGES`. - Now, only styles that require image clearing have a method for such. - Change: Removed all `_clear_images()` methods. - Change: Updated the docstrings of `_clear_frame()` methods. - Change: Updated affected aspects of the TUI.
AnonymouX47
force-pushed
the
render-style-updates
branch
from
396f747
to
4448a70
Compare
- Add: Added render style metaclass `.image.ImageMeta`. - Changed the metaclass of `BaseImage`. - Add: Added `ImageMeta.style` property. - Add: Added tests for `ImageMeta.style` and str(ImageClass). - Change: `str(ImageClass)` not returns the name of the render style [category].
- Change: Now using `ImageClass.style` instead of `.cli.args.style`. - Change: `.cli.args.style` is no longer updated after parsing/processing CL args.
- Fix: The render style is no longer forced when `--style` is specified and the value is the same that of the "style" config option. - Now, the style is forced only when `--style` is not specified and "style" != "auto"... as specified in the docs.
Conflicts: src/term_image/cli.py src/term_image/tui/widgets.py
AnonymouX47
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear()method to each ofKittyImageandIterm2Image..image.ImageMeta.ImageMeta.styleproperty.str(ImageClass)now returns the name of the render style [category].