Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font/Cell ratio improvements #68

Merged
merged 6 commits into from Sep 6, 2022
Merged

Font/Cell ratio improvements #68

merged 6 commits into from Sep 6, 2022

Conversation

AnonymouX47
Copy link
Owner

@AnonymouX47 AnonymouX47 commented Aug 3, 2022 •
edited

  • Changes "FONT ratio" to "CELL ratio"!!
    • term_image.get_font_ratio() -> term_image.get_cell_ratio()
    • term_image.set_font_ratio() -> term_image.set_cell_ratio()
    • -F/--font-ratio -> -C/--cell-ratio
    • --auto-font-ratio -> --auto-cell-ratio
    • config option "font ratio" -> "cell ratio"
    • etc...
  • Renames FontRatio enum to AutoCellRatio.
  • Renames modes AUTO -> FIXED and FULL_AUTO -> DYNAMIC.
  • Makes the auto cell ratio support status override public.

@AnonymouX47
[lib] Revamped auto font ratio
c904024 
- Change: Renamed the `FontRatio` enum to `AutoFontRatio`.
- Chnage: Renamed modes `AUTO` -> `FIXED` and `FULL_AUTO` -> `DYNAMIC`.
- Change: Made the support status override public.
  - Moved `term_image._auto_font_ratio` to `AutoFontRatio.is_supported`.
- Change: Updated docstrings.
- Change: Updated affected aspects of the CLI and TUI.
@AnonymouX47 AnonymouX47 added documentation Improvements or additions to documentation text Related to the interface common to text-based render styles improvement Implementation of improvement to an existing feature labels Aug 3, 2022
@AnonymouX47 AnonymouX47 added this to the 0.5.0 milestone Aug 3, 2022
@AnonymouX47 AnonymouX47 added lib Related to the library (Not to be used anymore) cli Related to the image viewer's CLI (Not to be used anymore) tui Related to the image viewer's TUI (Not to be used anymore) config Related to the viewer configuration (Not to be used anymore) test Related to the test suite labels Sep 6, 2022
@AnonymouX47
"FONT ratio" -> "CELL ratio"
2342d92 
- Change: [lib] Renamed:
  - `term_image.get_font_ratio()` -> `term_image.get_cell_ratio()`
  - `term_image.set_font_ratio()` -> `term_image.set_cell_ratio()`
  - `term_image.AutoFontRatio()` -> `term_image.AutoCellRatio()`
- Change: [cli] Renamed:
  - `-F/--font-ratio` -> `-C/--cell-ratio`
  - `--auto-font-ratio` -> `--auto-cell-ratio`
- Change: [config] Renamed:
  - "font ratio" -> "cell ratio"
- Change: [cli,tui,test,docs] Updated names to reflect the changes.
@AnonymouX47
Updated the changelog for #68
401cd39
@AnonymouX47 AnonymouX47 merged commit 830a9e5 into main Sep 6, 2022
@AnonymouX47 AnonymouX47 deleted the font-cell-ratio branch September 6, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli Related to the image viewer's CLI (Not to be used anymore) config Related to the viewer configuration (Not to be used anymore) documentation Improvements or additions to documentation improvement Implementation of improvement to an existing feature lib Related to the library (Not to be used anymore) test Related to the test suite text Related to the interface common to text-based render styles tui Related to the image viewer's TUI (Not to be used anymore)
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AnonymouX47