Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid DeprecationWarning #106

Merged
merged 1 commit into from Jul 24, 2018
Merged

Avoid DeprecationWarning #106

merged 1 commit into from Jul 24, 2018

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Jun 29, 2018

Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working.

Preserves Python 2 compatibility.

Using or importing the ABCs from 'collections' instead of from
'collections.abc' is deprecated, and in 3.8 it will stop working.

Preserves Python 2 compatibility.
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment saying which part is for Python 2 and which for Python 3?

That would make it clear which bit of code to clean up when Python 2.7 is EOL (2020-01-01).

@hroncok
Copy link
Contributor Author

hroncok commented Jul 24, 2018

I don't think that's necessary. It's obvious from git blame and also easy to try.

@Anorov Anorov merged commit 2c3ec57 into Anorov:master Jul 24, 2018
@hugovk
Copy link
Contributor

hugovk commented Oct 6, 2018

@Anorov Is there a schedule for the next release? It would be really nice to have this out. Thank you!

@hugovk
Copy link
Contributor

hugovk commented Oct 21, 2018

In the meantime, here's how to install the latest dev version:

pip install -U git+https://github.com/Anorov/PySocks

Or with the latest commit:

pip install -U git+https://github.com/Anorov/PySocks@b687a3402aaad60716c8d343bdfd091aaec705c3

@jaraco
Copy link

jaraco commented Jan 1, 2019

I ran into this issue today. Would be nice to see a release to avoid having to add workarounds.

jaraco added a commit to jaraco/jaraco.pmxbot that referenced this pull request Jan 1, 2019
@hroncok hroncok deleted the abc branch January 1, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants