Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing PySocks on Windows + Python 2.7 no longer installs win-inet-pton #131

Open
pquentin opened this issue Oct 28, 2019 · 0 comments

Comments

@pquentin
Copy link

#89 modified setup.py to install win-inet-pton on Windows + Python 2.7. This worked fine for source releases. However, 1.7.0 and 1.7.1 were released as wheels, and no longer include this addition, which breaks the urllib3 tests.

I guess there are three options:

  • remove mentions of win-inet-pton in setup.py and explain in the README that it should be installed separately
  • provide a Python 2.7 + Windows wheel for each release
  • Stop supporting Python 2.7 with python_requires in setup.py

Thanks!

@pquentin pquentin changed the title Installing PySocs on Windows + Python 2.7 no longer installs win-inet-pton Installing PySocks on Windows + Python 2.7 no longer installs win-inet-pton Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant