Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor intrinsic func to allow customize it outside #11

Merged
merged 3 commits into from Dec 13, 2023

Conversation

zoowii
Copy link
Collaborator

@zoowii zoowii commented Dec 12, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • [ x ] N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • [ x ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • [ x ] N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • [ x ] Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Signed-off-by: zoowii <shaoding.zw@antgroup.com>
Signed-off-by: zoowii <shaoding.zw@antgroup.com>
Signed-off-by: zoowii <shaoding.zw@antgroup.com>
@zoowii zoowii changed the title Zoowii/refactor intrinsic func name enum refactor intrinsic func name enum Dec 12, 2023
@zoowii
Copy link
Collaborator Author

zoowii commented Dec 12, 2023

I have read the CLA Document and I hereby sign the CLA

@zoowii zoowii changed the title refactor intrinsic func name enum refactor intrinsic func to allow customize it outside Dec 12, 2023
@i-zhen i-zhen self-requested a review December 13, 2023 04:25
Copy link
Contributor

@i-zhen i-zhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i-zhen i-zhen merged commit 40e450b into main Dec 13, 2023
3 checks passed
@i-zhen i-zhen deleted the zoowii/refactor_intrinsic_func_name_enum branch December 13, 2023 04:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants