Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify names in ir and ir_cli crates #7

Merged
merged 8 commits into from Dec 12, 2023
Merged

Conversation

Peefy
Copy link
Collaborator

@Peefy Peefy commented Dec 11, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: unify names in ir and ir_cli crates

  • Hostapi -> HostAPI
  • HostAPI -> HostAPI
  • HOSTAPI -> HostAPI
  • Defination -> MetadataDefinition

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copy link

github-actions bot commented Dec 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Peefy
Copy link
Collaborator Author

Peefy commented Dec 11, 2023

I have read the CLA Document and I hereby sign the CLA

@amyXia1994
Copy link
Collaborator

/recheck

Signed-off-by: peefy <xpf6677@163.com>
amyXia1994 and others added 7 commits December 12, 2023 11:37
Signed-off-by: xiarui.xr <xiarui.xr@antgroup.com>
Signed-off-by: i-zhen <zhenyi.zhen@antgroup.com>
Signed-off-by: xiarui.xr <xiarui.xr@antgroup.com>
Signed-off-by: xiarui.xr <xiarui.xr@antgroup.com>
Signed-off-by: xiarui.xr <xiarui.xr@antgroup.com>
Signed-off-by: xiarui.xr <xiarui.xr@antgroup.com>
Signed-off-by: peefy <xpf6677@163.com>
Copy link
Contributor

@i-zhen i-zhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@i-zhen i-zhen merged commit aeff427 into main Dec 12, 2023
3 checks passed
@i-zhen i-zhen deleted the refactor-unify-name branch December 12, 2023 05:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants