Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement early-forfeit logic #65

Closed
Antar1011 opened this issue Oct 4, 2016 · 3 comments
Closed

Implement early-forfeit logic #65

Antar1011 opened this issue Oct 4, 2016 · 3 comments
Labels
feature
Milestone
0.1 Release

Comments

@Antar1011
Copy link
Owner

Non-6v6 and non-singles formats are exempt their battles from being filtered out for being "early forfeits." The logic to check this needs to be implemented.
@Antar1011 Antar1011 added this to the 0.1 Release milestone Oct 4, 2016
@Antar1011
Copy link
Owner Author

Honestly? I might just want to start discarding early forfeits altogether. Weighted stats should take care of this.

@Antar1011
Copy link
Owner Author

Functionality should be there regardless of future policy.

@Antar1011 Antar1011 mentioned this issue Oct 11, 2016
Merged
@Antar1011
Copy link
Owner Author

#72 resolves this by setting it as a kwarg in the report generator, rather than setting it automatically, since the policy is currently up for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.1 Release
Development

No branches or pull requests
1 participant
@Antar1011