Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop appending GUID string after cleanup app domain name #577

Open
Yaming-Hub opened this issue Mar 7, 2021 · 0 comments
Open

Stop appending GUID string after cleanup app domain name #577

Yaming-Hub opened this issue Mar 7, 2021 · 0 comments

Comments

@Yaming-Hub
Copy link

Razor engine will automatically setup a clean up helper app domain to unload files after main app domain is unloaded, the logic is in defined in https://github.com/Antaris/RazorEngine/blob/master/src/source/RazorEngine.Core/Compilation/CrossAppDomainCleanUp.cs class. The problem is, the help app domain name is always "CleanupHelperDomain_" format. Our application will be running on tens of thousands of machines and we use app domain as one dimension to track the memory consumption of each application. Given the help app domain name contains a random GUID every time, it make aggregation become impossible.

The ask is to either remove the random GUID name from from clean up app domain (we can use a hard coded GUID to ensure the uniqueness of the app domain), or make the clean up domain name configurable so that caller can decide what name should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant