Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port inline multisig changes from eosio.contracts #7

Closed
arhag opened this issue Oct 4, 2022 · 0 comments · Fixed by #11
Closed

Port inline multisig changes from eosio.contracts #7

arhag opened this issue Oct 4, 2022 · 0 comments · Fixed by #11
Assignees

Comments

@arhag
Copy link
Member

arhag commented Oct 4, 2022

These changes (EOSIO/eosio.contracts@v1.8.3...9895b08) were lost in the transition from eosio.contracts to mandel-contracts, which then was carried forward into eos-system-contracts and reference-contracts.

We want to capture that functionality in the main branch of reference-contracts.

Some of the changes may only be there to workaround CDT issues that are already fixed. If there are simplifications in the code possible while maintaining the same behavior in the modified eosio.msig contract by assuming CDT v3.0.0 or later can be used, then go ahead and make those simplifications.

In addition, make sure that the eosio.wrap contract also uses inline actions instead of deferred transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants